Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support basic math operations #5

Open
flosse opened this issue Jul 25, 2018 · 4 comments
Open

support basic math operations #5

flosse opened this issue Jul 25, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@flosse
Copy link
Member

flosse commented Jul 25, 2018

I'd like to express conditions like |fcr001 - fcr002| > 0.5, so the two math. operations Sub and Abs could do the start :)

@flosse flosse added the enhancement New feature or request label Jul 25, 2018
@NOP0
Copy link

NOP0 commented May 18, 2020

@flosse I was just looking at the compare module. Could pub enum Comparator be renamed pub enum Operator and used as such? I.e. Operator::Sub, Operator::Abs.

Side note: How active is this project? I think it's interesting, and looking for maybe doing some simple PR but I'm not sure whether anyone is using it? 🙂

@flosse
Copy link
Member Author

flosse commented May 19, 2020

@flosse I was just looking at the compare module. Could pub enum Comparator be renamed pub enum Operator and used as such? I.e. Operator::Sub, Operator::Abs.

I'd rather replace the whole module with something else that already exists because I don't want to reinvent the wheel and I don't want to create a new programming language ;-)

Side note: How active is this project? I think it's interesting, and looking for maybe doing some simple PR but I'm not sure whether anyone is using it? 🙂

We're currently working on a new version (it's not opensourced yet) that won't be compatible with the current msr version but it will be much more powerful 😄
Would you mind to share your use case? What are you going to build?

@NOP0
Copy link

NOP0 commented May 19, 2020

I'd rather replace the whole module with something else that already exists because I don't want to reinvent the wheel and I don't want to create a new programming language ;-)

I agree 🙂

We're currently working on a new version

Okay, I'll just wait and see what the next version brings then, no point in working on the old one 👍
I don't have a use case right now, I'm just very interested in the PLC/Automation/Rust intersection/combo. I think it could have a lot to offer 😄

@NOP0
Copy link

NOP0 commented Oct 11, 2021

Great to see a new version come together. Please post any entry level issues if you like, and keep up the good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants