-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateState no longer called when changing URL query parameter #484
Comments
Hey @ryanaston I will try to reproduce and will let you know when |
Was this issue addressed in 1.4.1? |
Hey @ryanaston Thanks for reminding me of this as I clearly forgot. I managed to find the culprit and fix it - you can see in the commit what was wrong. It was a bit tricky to test it (I'll need to restructure the tests some time soon...), but it should work now. Thanks again for your patience. |
Describe the bug
I have a BeamLocation that overrides updateState in order to notify some widgets down the tree when a query parameter in the URL has changed. In 1.3.0 this worked perfectly. However, when I upgraded to 1.4.0 this stopped working. After a bit of digging I found that "updateState" is no longer being called when the query parameter changes, thus preventing me from notifying my child widgets that the parameter has changed. I have a hunch this is related to change #475. Unfortunately I don't have much time to dig further and have rolled back to 1.3.0.
Beamer version: 1.4.0
To Reproduce
Steps to reproduce the behavior:
/#/?date=2022-02-28
/#/?date=2022-02-27
Expected behavior
updateState would be called when the query parameter changes
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: