Crash upon opening repository #1017
Comments
|
Note to self: crash is due to this part in the repo events: {
"id": "13240590208",
"type": "PullRequestReviewEvent",
"actor": {
"id": 49363530,
"login": "monocodus[bot]",
"display_login": "monocodus",
"gravatar_id": "",
"url": "https://api.github.com/users/monocodus[bot]",
"avatar_url": "https://avatars.githubusercontent.com/u/49363530?"
},
"repo": {
"id": 148563979,
"name": "gfx-rs/naga",
"url": "https://api.github.com/repos/gfx-rs/naga"
},
"payload": {
"action": "created",
"review": {
"id": 470164393,
"node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDcwMTY0Mzkz",
"user": {
"login": "monocodus[bot]",
"id": 49363530,
"node_id": "MDM6Qm90NDkzNjM1MzA=",
"avatar_url": "https://avatars3.githubusercontent.com/in/28526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monocodus%5Bbot%5D",
"html_url": "https://github.com/apps/monocodus",
"followers_url": "https://api.github.com/users/monocodus%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/monocodus%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/monocodus%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/monocodus%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/monocodus%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/monocodus%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/monocodus%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/monocodus%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/monocodus%5Bbot%5D/received_events",
"type": "Bot",
"site_admin": false
},
"body": "",
"commit_id": "91e3f22bab76487f768640c67175c5e53ae874f1",
"submitted_at": "2020-08-19T06:40:22Z",
"state": "approved",
"html_url": "https://github.com/gfx-rs/naga/pull/140#pullrequestreview-470164393",
"pull_request_url": "https://api.github.com/repos/gfx-rs/naga/pulls/140",
"author_association": "NONE",
"_links": {
"html": {
"href": "https://github.com/gfx-rs/naga/pull/140#pullrequestreview-470164393"
},
"pull_request": {
"href": "https://api.github.com/repos/gfx-rs/naga/pulls/140"
}
}
},
"pull_request": {
"url": "https://api.github.com/repos/gfx-rs/naga/pulls/140",
"id": 469949309,
"node_id": "MDExOlB1bGxSZXF1ZXN0NDY5OTQ5MzA5",
"html_url": "https://github.com/gfx-rs/naga/pull/140",
"diff_url": "https://github.com/gfx-rs/naga/pull/140.diff",
"patch_url": "https://github.com/gfx-rs/naga/pull/140.patch",
"issue_url": "https://api.github.com/repos/gfx-rs/naga/issues/140",
"number": 140,
"state": "open",
"locked": false,
"title": "Interpolation support for wgsl, glsl, glsl-new, spirv (front and back), and glsl-out",
"user": {
"login": "lachlansneff",
"id": 31360811,
"node_id": "MDQ6VXNlcjMxMzYwODEx",
"avatar_url": "https://avatars3.githubusercontent.com/u/31360811?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lachlansneff",
"html_url": "https://github.com/lachlansneff",
"followers_url": "https://api.github.com/users/lachlansneff/followers",
"following_url": "https://api.github.com/users/lachlansneff/following{/other_user}",
"gists_url": "https://api.github.com/users/lachlansneff/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lachlansneff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lachlansneff/subscriptions",
"organizations_url": "https://api.github.com/users/lachlansneff/orgs",
"repos_url": "https://api.github.com/users/lachlansneff/repos",
"events_url": "https://api.github.com/users/lachlansneff/events{/privacy}",
"received_events_url": "https://api.github.com/users/lachlansneff/received_events",
"type": "User",
"site_admin": false
},
"body": "This pr adds interpolation qualifier support to naga itself, as well as all frontends and all backends except `msl` (I don'+t know `msl` well enough). You may notice that includes `wgsl`. While there has been no official declaration of how interpolation qualifier+s will make their way into wgsl, [this](https://github.com/gpuweb/gpuweb/issues/802) issue gave some good options, and I went with the one +(the second) that seemed better to me. Easy enough to change down the line.\r\n\r\nWhile I was able to test most of these, the spirv fronte+nd was having issues that were unrelated to my changes and so I couldn't test it.",
"created_at": "2020-08-19T06:22:44Z",
"updated_at": "2020-08-19T06:40:22Z",
"closed_at": null,
"merged_at": null,
"merge_commit_sha": "e9f7723f507d4947ab101fe6491a276ccd3c3edb",
"assignee": null,
"assignees": [
],
"requested_reviewers": [
],
"requested_teams": [
],
"labels": [
],
"milestone": null,
"draft": false,
"commits_url": "https://api.github.com/repos/gfx-rs/naga/pulls/140/commits",
"review_comments_url": "https://api.github.com/repos/gfx-rs/naga/pulls/140/comments",
"review_comment_url": "https://api.github.com/repos/gfx-rs/naga/pulls/comments{/number}",
"comments_url": "https://api.github.com/repos/gfx-rs/naga/issues/140/comments",
"statuses_url": "https://api.github.com/repos/gfx-rs/naga/statuses/91e3f22bab76487f768640c67175c5e53ae874f1",
"head": {
"label": "lachlansneff:interpolation",
"ref": "interpolation",
"sha": "91e3f22bab76487f768640c67175c5e53ae874f1",
"user": {
"login": "lachlansneff",
"id": 31360811,
"node_id": "MDQ6VXNlcjMxMzYwODEx",
"avatar_url": "https://avatars3.githubusercontent.com/u/31360811?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lachlansneff",
"html_url": "https://github.com/lachlansneff",
"followers_url": "https://api.github.com/users/lachlansneff/followers",
"following_url": "https://api.github.com/users/lachlansneff/following{/other_user}",
"gists_url": "https://api.github.com/users/lachlansneff/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lachlansneff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lachlansneff/subscriptions",
"organizations_url": "https://api.github.com/users/lachlansneff/orgs",
"repos_url": "https://api.github.com/users/lachlansneff/repos",
"events_url": "https://api.github.com/users/lachlansneff/events{/privacy}",
"received_events_url": "https://api.github.com/users/lachlansneff/received_events",
"type": "User",
"site_admin": false
},
"repo": {
"id": 287178279,
"node_id": "MDEwOlJlcG9zaXRvcnkyODcxNzgyNzk=",
"name": "naga",
"full_name": "lachlansneff/naga",
"private": false,
"owner": {
"login": "lachlansneff",
"id": 31360811,
"node_id": "MDQ6VXNlcjMxMzYwODEx",
"avatar_url": "https://avatars3.githubusercontent.com/u/31360811?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lachlansneff",
"html_url": "https://github.com/lachlansneff",
"followers_url": "https://api.github.com/users/lachlansneff/followers",
"following_url": "https://api.github.com/users/lachlansneff/following{/other_user}",
"gists_url": "https://api.github.com/users/lachlansneff/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lachlansneff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lachlansneff/subscriptions",
"organizations_url": "https://api.github.com/users/lachlansneff/orgs",
"repos_url": "https://api.github.com/users/lachlansneff/repos",
"events_url": "https://api.github.com/users/lachlansneff/events{/privacy}",
"received_events_url": "https://api.github.com/users/lachlansneff/received_events",
"type": "User",
"site_admin": false
},
"html_url": "https://github.com/lachlansneff/naga",
"description": "Universal shader translation in Rust",
"fork": true,
"url": "https://api.github.com/repos/lachlansneff/naga",
"forks_url": "https://api.github.com/repos/lachlansneff/naga/forks",
"keys_url": "https://api.github.com/repos/lachlansneff/naga/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/lachlansneff/naga/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/lachlansneff/naga/teams",
"hooks_url": "https://api.github.com/repos/lachlansneff/naga/hooks",
"issue_events_url": "https://api.github.com/repos/lachlansneff/naga/issues/events{/number}",
"events_url": "https://api.github.com/repos/lachlansneff/naga/events",
"assignees_url": "https://api.github.com/repos/lachlansneff/naga/assignees{/user}",
"branches_url": "https://api.github.com/repos/lachlansneff/naga/branches{/branch}",
"tags_url": "https://api.github.com/repos/lachlansneff/naga/tags",
"blobs_url": "https://api.github.com/repos/lachlansneff/naga/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/lachlansneff/naga/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/lachlansneff/naga/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/lachlansneff/naga/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/lachlansneff/naga/statuses/{sha}",
"languages_url": "https://api.github.com/repos/lachlansneff/naga/languages",
"stargazers_url": "https://api.github.com/repos/lachlansneff/naga/stargazers",
"contributors_url": "https://api.github.com/repos/lachlansneff/naga/contributors",
"subscribers_url": "https://api.github.com/repos/lachlansneff/naga/subscribers",
"subscription_url": "https://api.github.com/repos/lachlansneff/naga/subscription",
"commits_url": "https://api.github.com/repos/lachlansneff/naga/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/lachlansneff/naga/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/lachlansneff/naga/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/lachlansneff/naga/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/lachlansneff/naga/contents/{+path}",
"compare_url": "https://api.github.com/repos/lachlansneff/naga/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/lachlansneff/naga/merges",
"archive_url": "https://api.github.com/repos/lachlansneff/naga/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/lachlansneff/naga/downloads",
"issues_url": "https://api.github.com/repos/lachlansneff/naga/issues{/number}",
"pulls_url": "https://api.github.com/repos/lachlansneff/naga/pulls{/number}",
"milestones_url": "https://api.github.com/repos/lachlansneff/naga/milestones{/number}",
"notifications_url": "https://api.github.com/repos/lachlansneff/naga/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/lachlansneff/naga/labels{/name}",
"releases_url": "https://api.github.com/repos/lachlansneff/naga/releases{/id}",
"deployments_url": "https://api.github.com/repos/lachlansneff/naga/deployments",
"created_at": "2020-08-13T04:11:06Z",
"updated_at": "2020-08-19T03:14:14Z",
"pushed_at": "2020-08-19T06:38:29Z",
"git_url": "git:https://github.com/lachlansneff/naga.git",
"ssh_url": "[email protected]:lachlansneff/naga.git",
"clone_url": "https://github.com/lachlansneff/naga.git",
"svn_url": "https://github.com/lachlansneff/naga",
"homepage": "",
"size": 437,
"stargazers_count": 0,
"watchers_count": 0,
"language": "Rust",
"has_issues": false,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 0,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 0,
"license": {
"key": "apache-2.0",
"name": "Apache License 2.0",
"spdx_id": "Apache-2.0",
"url": "https://api.github.com/licenses/apache-2.0",
"node_id": "MDc6TGljZW5zZTI="
},
"forks": 0,
"open_issues": 0,
"watchers": 0,
"default_branch": "master"
}
},
"base": {
"label": "gfx-rs:master",
"ref": "master",
"sha": "58dd54f938f66a22a96a792c070a3dcadc84bfef",
"user": {
"login": "gfx-rs",
"id": 8213174,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjgyMTMxNzQ=",
"avatar_url": "https://avatars3.githubusercontent.com/u/8213174?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gfx-rs",
"html_url": "https://github.com/gfx-rs",
"followers_url": "https://api.github.com/users/gfx-rs/followers",
"following_url": "https://api.github.com/users/gfx-rs/following{/other_user}",
"gists_url": "https://api.github.com/users/gfx-rs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gfx-rs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gfx-rs/subscriptions",
"organizations_url": "https://api.github.com/users/gfx-rs/orgs",
"repos_url": "https://api.github.com/users/gfx-rs/repos",
"events_url": "https://api.github.com/users/gfx-rs/events{/privacy}",
"received_events_url": "https://api.github.com/users/gfx-rs/received_events",
"type": "Organization",
"site_admin": false
},
"repo": {
"id": 148563979,
"node_id": "MDEwOlJlcG9zaXRvcnkxNDg1NjM5Nzk=",
"name": "naga",
"full_name": "gfx-rs/naga",
"private": false,
"owner": {
"login": "gfx-rs",
"id": 8213174,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjgyMTMxNzQ=",
"avatar_url": "https://avatars3.githubusercontent.com/u/8213174?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gfx-rs",
"html_url": "https://github.com/gfx-rs",
"followers_url": "https://api.github.com/users/gfx-rs/followers",
"following_url": "https://api.github.com/users/gfx-rs/following{/other_user}",
"gists_url": "https://api.github.com/users/gfx-rs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gfx-rs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gfx-rs/subscriptions",
"organizations_url": "https://api.github.com/users/gfx-rs/orgs",
"repos_url": "https://api.github.com/users/gfx-rs/repos",
"events_url": "https://api.github.com/users/gfx-rs/events{/privacy}",
"received_events_url": "https://api.github.com/users/gfx-rs/received_events",
"type": "Organization",
"site_admin": false
},
"html_url": "https://github.com/gfx-rs/naga",
"description": "Universal shader translation in Rust",
"fork": false,
"url": "https://api.github.com/repos/gfx-rs/naga",
"forks_url": "https://api.github.com/repos/gfx-rs/naga/forks",
"keys_url": "https://api.github.com/repos/gfx-rs/naga/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/gfx-rs/naga/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/gfx-rs/naga/teams",
"hooks_url": "https://api.github.com/repos/gfx-rs/naga/hooks",
"issue_events_url": "https://api.github.com/repos/gfx-rs/naga/issues/events{/number}",
"events_url": "https://api.github.com/repos/gfx-rs/naga/events",
"assignees_url": "https://api.github.com/repos/gfx-rs/naga/assignees{/user}",
"branches_url": "https://api.github.com/repos/gfx-rs/naga/branches{/branch}",
"tags_url": "https://api.github.com/repos/gfx-rs/naga/tags",
"blobs_url": "https://api.github.com/repos/gfx-rs/naga/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/gfx-rs/naga/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/gfx-rs/naga/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/gfx-rs/naga/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/gfx-rs/naga/statuses/{sha}",
"languages_url": "https://api.github.com/repos/gfx-rs/naga/languages",
"stargazers_url": "https://api.github.com/repos/gfx-rs/naga/stargazers",
"contributors_url": "https://api.github.com/repos/gfx-rs/naga/contributors",
"subscribers_url": "https://api.github.com/repos/gfx-rs/naga/subscribers",
"subscription_url": "https://api.github.com/repos/gfx-rs/naga/subscription",
"commits_url": "https://api.github.com/repos/gfx-rs/naga/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/gfx-rs/naga/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/gfx-rs/naga/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/gfx-rs/naga/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/gfx-rs/naga/contents/{+path}",
"compare_url": "https://api.github.com/repos/gfx-rs/naga/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/gfx-rs/naga/merges",
"archive_url": "https://api.github.com/repos/gfx-rs/naga/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/gfx-rs/naga/downloads",
"issues_url": "https://api.github.com/repos/gfx-rs/naga/issues{/number}",
"pulls_url": "https://api.github.com/repos/gfx-rs/naga/pulls{/number}",
"milestones_url": "https://api.github.com/repos/gfx-rs/naga/milestones{/number}",
"notifications_url": "https://api.github.com/repos/gfx-rs/naga/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/gfx-rs/naga/labels{/name}",
"releases_url": "https://api.github.com/repos/gfx-rs/naga/releases{/id}",
"deployments_url": "https://api.github.com/repos/gfx-rs/naga/deployments",
"created_at": "2018-09-13T01:26:50Z",
"updated_at": "2020-08-19T05:40:21Z",
"pushed_at": "2020-08-19T06:38:31Z",
"git_url": "git:https://github.com/gfx-rs/naga.git",
"ssh_url": "[email protected]:gfx-rs/naga.git",
"clone_url": "https://github.com/gfx-rs/naga.git",
"svn_url": "https://github.com/gfx-rs/naga",
"homepage": "",
"size": 449,
"stargazers_count": 167,
"watchers_count": 167,
"language": "Rust",
"has_issues": true,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 15,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 31,
"license": {
"key": "apache-2.0",
"name": "Apache License 2.0",
"spdx_id": "Apache-2.0",
"url": "https://api.github.com/licenses/apache-2.0",
"node_id": "MDc6TGljZW5zZTI="
},
"forks": 15,
"open_issues": 31,
"watchers": 167,
"default_branch": "master"
}
},
"_links": {
"self": {
"href": "https://api.github.com/repos/gfx-rs/naga/pulls/140"
},
"html": {
"href": "https://github.com/gfx-rs/naga/pull/140"
},
"issue": {
"href": "https://api.github.com/repos/gfx-rs/naga/issues/140"
},
"comments": {
"href": "https://api.github.com/repos/gfx-rs/naga/issues/140/comments"
},
"review_comments": {
"href": "https://api.github.com/repos/gfx-rs/naga/pulls/140/comments"
},
"review_comment": {
"href": "https://api.github.com/repos/gfx-rs/naga/pulls/comments{/number}"
},
"commits": {
"href": "https://api.github.com/repos/gfx-rs/naga/pulls/140/commits"
},
"statuses": {
"href": "https://api.github.com/repos/gfx-rs/naga/statuses/91e3f22bab76487f768640c67175c5e53ae874f1"
}
},
"author_association": "CONTRIBUTOR",
"active_lock_reason": null
}
},
"public": true,
"created_at": "2020-08-19T06:40:22Z",
"org": {
"id": 8213174,
"login": "gfx-rs",
"gravatar_id": "",
"url": "https://api.github.com/orgs/gfx-rs",
"avatar_url": "https://avatars.githubusercontent.com/u/8213174?"
}
},... which is a I'll update the bindings accordingly. |
|
It crashes also while opening https://github.com/rectorphp/rector |
|
@vjandrea Yeah, that one has the same root cause. Support ticket: https://github.community/t/rest-api-unknown-event-type-pullrequestreviewevent/128476 |
|
Found another crasher https://github.com/knurling-rs/probe-run |
|
@maniac103 also when I click on vjandrea's profile in this issue, the app crashes. |
Same root cause, that time it's a |
|
@maniac103 please push the new version with this fix to the store. I'm facing a ton of repositories that crash, making the app unusable. |
|
Yeah, I'll do a release in the next three days. Guess when they released that change, judging from the crash counts:
;-) |
|
The above repositories don't crash for me. But https://github.com/openwrt/openwrt crashes on some PR event, which looks related to me: Full stacktrace: |
It's not just related, it's the very same thing ;-) |
I've created a 4.6.3 release and uploaded to Google Play, it's currently in review there. |
|
Out now! Thank you very much! |
|
Is this pushed to fdroid also? |
|
F-Droid builds should AFAIK just pick up the new tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I open this repository, the app crashes.
The text was updated successfully, but these errors were encountered: