Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] API rate limit exceeded #1013

Closed
KaKi87 opened this issue Aug 5, 2020 · 12 comments
Closed

[Question] API rate limit exceeded #1013

KaKi87 opened this issue Aug 5, 2020 · 12 comments

Comments

@KaKi87
Copy link

KaKi87 commented Aug 5, 2020

Hello,

API rate limit exceeded for user ID 21284089 (403)

I'm getting a lot of these lately, while I didn't used to in my first months using OctoDroid.

What changed ?

Thanks

@maniac103
Copy link
Collaborator

I don't think anything specific has changed ... at least I never saw that error in my own Octodroid usage. The docs say you have 5000 requests per hour shared among all apps you're logged into ... do you maybe use more than one app that uses a GH token for your account?

@KaKi87
Copy link
Author

KaKi87 commented Aug 29, 2020

I've just discovered that OctoDroid make a lot of these requests

@maniac103
Copy link
Collaborator

Interesting. I assume you have notifications enabled? If so, this almost feels like the notifications worker is retriggered over and over again.
Can you reproduce this at will? If so, I assume the issue goes away when disabling notifications?

@KaKi87
Copy link
Author

KaKi87 commented Aug 29, 2020

You guessed everything right.

@maniac103
Copy link
Collaborator

OK, in that case I'll double check the notifications code and maybe add some debug logging. Would you be willing to test drive a build with more debug output?

@KaKi87
Copy link
Author

KaKi87 commented Aug 29, 2020

Yes, preferably built as an APK and outputting logs in a local file. Thanks

@KaKi87
Copy link
Author

KaKi87 commented Sep 8, 2020

So you fixed it anyway ? ^^
Did you found out why it only happened to me ?
When will the fix be released in Google Play ?

@maniac103
Copy link
Collaborator

Did you found out why it only happened to me ?

I have no idea why you had that many workers running, but when adding debug logging I found that I also had 4 or 5 running simultaneously.

When will the fix be released in Google Play ?

In the next 1 or 2 weeks, I want to test drive the new code for check run support for a few days.

@mqus
Copy link

mqus commented Oct 3, 2020

I'm not entirely sure because I did not check the logs but I think this bug took up most of my mobile data volume eventhough I was barely outside last month. Now after I applied the update I also noticed that my battery also lasts twice to thrice as long as before, probably due to the frequent waking.
All I want to say is thank you! You postponed my decision to buy a new phone at least a year :D

@KaKi87
Copy link
Author

KaKi87 commented Oct 3, 2020

I'd believe you regarding baterry because loops and requests do take energy, however, they're just API calls so they only contain text, they're lightweight. What's your data plan size?

@mqus
Copy link

mqus commented Oct 3, 2020

It took up about 750mb of mostly backgrounddata over at most 24(?) hours in total, stretched over a month. I know it's ridiculous. I even set the sync interval to an hour but it didn't have an effect. But as written, I think those are solved now. I now also prevented octodroid from using background data during outside activities to prevent something like this from happening again.

@KaKi87
Copy link
Author

KaKi87 commented Oct 3, 2020

Alright 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants