Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background dimming animation broken #72

Closed
4 tasks done
danqing opened this issue Nov 28, 2019 · 1 comment · Fixed by #77
Closed
4 tasks done

Background dimming animation broken #72

danqing opened this issue Nov 28, 2019 · 1 comment · Fixed by #77

Comments

@danqing
Copy link

danqing commented Nov 28, 2019

Description

After upgrading to the latest PanModal version, showing the pan modal no longer has background dimming animation. That is, while the modal animates up from the bottom, the black transparent background appears instantly without a fade-in effect.

Dismissing works fine: both the modal and the background has an animation for dismissal.

Expected: The dimming background should animate from alpha 0 to 1 when the pan modal is activated.

What type of issue is this? (place an x in one of the [ ])

  • bug

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@KyoheiG3
Copy link
Contributor

KyoheiG3 commented Jan 15, 2020

I located the problem.

But I'm not sure if I can delete this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants