Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: musl support #136

Closed
firasuke opened this issue Apr 28, 2021 · 4 comments · Fixed by #145
Closed

Feature: musl support #136

firasuke opened this issue Apr 28, 2021 · 4 comments · Fixed by #145
Labels
A-x86_64 Related to the x86_64 architecture C-enhancement New feature or request C-reliability This issue/PR relates to reliability C-Stability D-build Related to builds D-workflow Related to workflow files L-Easy Good for newcomers OS-NonGNU-Unix Related to BSD like platforms

Comments

@firasuke
Copy link

Description

Kindly consider supporting musl libc as it will prove benefitial for lots of embedded projects out there.
@firasuke firasuke added the C-enhancement New feature or request label Apr 28, 2021
@ohsayan
Copy link
Member

ohsayan commented Apr 28, 2021

Hey! Thanks for the suggestion. We were actually just discussing this on Discord. Feel free to tune in to the discussion

@ohsayan
Copy link
Member

ohsayan commented Apr 28, 2021

Binaries have been built off the current HEAD on next, try these out and let me know if you have any issues: https://dl.skytable.io/musl-test/379660f14c5d92dfe290597f4b2e4f8816f17eb9/

Specifically attempt to use the SSL component with a key/cert and let me know if you're able to use it without issues

@ohsayan ohsayan added A-x86_64 Related to the x86_64 architecture D-build Related to builds D-workflow Related to workflow files L-Easy Good for newcomers OS-Linux Linux related OS-NonGNU-Unix Related to BSD like platforms and removed OS-Linux Linux related labels Apr 28, 2021
@ohsayan
Copy link
Member

ohsayan commented Apr 29, 2021

As discussed on Skytable's discord channel, we've come to conclude that this is attainable. We'll work on this soon (and I've got to clean up the backlog of issues that we have)

@ohsayan ohsayan added C-Stability C-reliability This issue/PR relates to reliability labels Apr 29, 2021
@ohsayan ohsayan mentioned this issue May 7, 2021
Merged
@firasuke
Copy link
Author

firasuke commented May 7, 2021

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-x86_64 Related to the x86_64 architecture C-enhancement New feature or request C-reliability This issue/PR relates to reliability C-Stability D-build Related to builds D-workflow Related to workflow files L-Easy Good for newcomers OS-NonGNU-Unix Related to BSD like platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for MUSL x86_64 and fix CI scripts skytable/skytable
2 participants
@ohsayan @firasuke