Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement transport limit for public visors #1759

Open
0pcom opened this issue Mar 7, 2024 · 0 comments
Open

implement transport limit for public visors #1759

0pcom opened this issue Mar 7, 2024 · 0 comments
Labels
bug Something isn't working public visor

Comments

@0pcom
Copy link
Collaborator

0pcom commented Mar 7, 2024

There is no apparent limit on the number of transports that a public visor will accept.

However, there is a definite limit of the number of transports a visor can have. (approx. 250 from my tests)

There should be a limit on the number of transports that a public visor will accept specified in the visor config, with a sensible default value which is lower than the maximum number.

When this limit is reached, the public visor should de-register it's entry from the public visors service discovery so that no additional transports will be created to that public visor.

...

It would make sense to limit the number of connections to any given proxy or VPN server via similar mechanism ; however the issue for public visors is more urgent.

@0pcom 0pcom added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working public visor
Projects
None yet
Development

No branches or pull requests

1 participant