Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag to show relevant visor logging on skywire-cli proxy start & skywire-cli vpn start #1682

Open
0pcom opened this issue Nov 24, 2023 · 2 comments
Labels
apps enhancement New feature or request low priority We don't need to look into this now.

Comments

@0pcom
Copy link
Collaborator

0pcom commented Nov 24, 2023

The following is currently observed when starting the proxy or VPN from skywire-cli:

$ skywire-cli proxy start 0216356d7b5286d2c6ee9c579443c346f1d89bf86d9e8a6426d421580b3162d83c
Starting.............
Running!

After entering the command, Starting is printed, and every second it prints another . until the proxy has started, then it prints Running on a new line.

This was done because it might take the visor a while to get the needed transports and routes before even starting the proxy. So there would be no indication that anything was happening without even this simple logging.

When starting the proxy or VPN with skywire-cli it would be convenient if there was a flag to show the logging as it would print to the terminal if you were running the visor ; in order to have some idea of what was happening without needing the visor running in another terminal; or without needing to look anywhere else besides the terminal you are attempting to start the proxy or VPN in currently.

We should show only the logging specific to:

  • transport creation
  • route setup
  • the proxy or VPN starting

If invoked with the flag to show the logs ; it should:

  • keep logging from there, until you do ctrl+c
  • then stop the proxy or VPN.

With the flag that shows the logging, it should not give the terminal back until the proxy or VPN is stopped & it should be possible to stop it with ctrl+c

I recommend a similar flag to show logging for transport creation, at least.

@mrpalide mrpalide added the low priority We don't need to look into this now. label Nov 29, 2023
@mrpalide
Copy link
Contributor

mrpalide commented Nov 29, 2023

Unfortunately the infrastructure of rpcClient is not suitable for those logging you want. But ctrl+c signal now is ready on #1680.

So I make this ticket as low priority, and will back to it later for logging.

@0pcom
Copy link
Collaborator Author

0pcom commented Dec 19, 2023

indeed, not a critical issue to solve currently.

@0pcom 0pcom added the enhancement New feature or request label Dec 27, 2023
@0pcom 0pcom added the apps label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps enhancement New feature or request low priority We don't need to look into this now.
Projects
None yet
Development

No branches or pull requests

2 participants