-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handshake synchronyzation #343
Comments
The following log is the result of an intermediary node restart cycle of more than 100 times in which it reconnects with nodes A and B, while at the same time messages are sent over chat app from node A to node C and back. Data races regarding to handshakes seem to disappear (#346 ) with this PR. There are however chacha errors, note that all of them are the same:
|
If node B is not restarted, thus making route between nodes A and C stable chacha encryption error doesn't seems to appear while sending messages. |
Concern raised by @nkryuchkov
https://github.com/skycoin/skywire/blob/mainnet/pkg/transport/handshake.go#L48 until 56 those operations might need to be guarded by mutexes to prevent a wrong order between write and read operations, leading to chacha bug appearing when creating a transport.
The text was updated successfully, but these errors were encountered: