Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement app-related commands in skywire-cli and manager-node. #321

Open
2 of 3 tasks
evanlinjin opened this issue May 1, 2019 · 0 comments
Open
2 of 3 tasks
Assignees
Labels

Comments

@evanlinjin
Copy link

evanlinjin commented May 1, 2019

Branch: mainnet-dev

Background

After the separation of the proc and app concepts (Where a proc is an instance of a running app), the interfaces; node.RPC and node.RPCClient (as well as their implementations) need an update. And consequently, also the endpoints of manager.Node and skywire-cli.

Tasks

  • Replace the commented out methods of node.RPC/node.RPCClient with the following methods:

    • Apps() []app.Meta obtains all available apps.
    • StartProc(appName string, args []string, port uint16) (router.ProcID, error) runs a proc.
    • StopProc(pid router.ProcID) error stops a proc.
    • ListProcs() []router.ProcInfo lists all running procs. Note that ProcInfo is not implemented; it should be a combination of router.ProcID ,app.Meta and app.ExecConfig.
  • Write sub-commands for the aforementioned calls in skywire-cli.

  • Write endpoints for the aforementioned calls in manager.Node.

@evanlinjin evanlinjin added this to To do in Skywire Mainnet via automation May 1, 2019
@evanlinjin evanlinjin pinned this issue May 1, 2019
@ivcosla ivcosla self-assigned this May 1, 2019
@jdknives jdknives unpinned this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants