-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review time.sleep in tests #279
Comments
@Darkren on Discord:
|
Those tests has at least one defect - their duration is always time.Sleep duration + time of test itself. ...
select {
case <- thingHappened:
case <- time.After(delay):
t.Fatal("timeout")
} I counted 50 cases of using time.Sleep in *test.go |
Task(s)
time.Sleep
. Examine stability of test before start of work:or
note random FAILs if they will occure.
time.Sleep
from tests without changing their behaviourtime.Sleep
is justified - write a comment describing "why time.Sleep is justified in this test"Tests with time.Sleep
The text was updated successfully, but these errors were encountered: