Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'Ensure' to 'FillDefaults' for config members. #254

Open
evanlinjin opened this issue Mar 28, 2019 · 0 comments
Open

Change 'Ensure' to 'FillDefaults' for config members. #254

evanlinjin opened this issue Mar 28, 2019 · 0 comments
Labels
cleanup mainnet
Projects
Skywire Mainnet

Comments

@evanlinjin
Copy link

I really find it more descriptive yes, just a matter of being consistent with our naming. Can rename the other config method instead.

Originally posted by @ivcosla in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDEwOTE5Mw==/comments/review_comment
@evanlinjin evanlinjin changed the title Change 'Ensure' to 'FillDefaults' for config endpoints. Change 'Ensure' to 'FillDefaults' for config members. Mar 28, 2019
@evanlinjin evanlinjin added this to To do in Skywire Mainnet via automation Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup mainnet
Projects
No open projects
Skywire Mainnet
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivcosla @evanlinjin @jdknives