New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved model_spike #204

Open

capelastegui opened this issue Apr 29, 2021 · 0 comments

Labels

Contributor

capelastegui commented Apr 29, 2021

Implement the following improvements for model_spike:

cache variables, see In model functions, cache costly, redundant operations #197
new model: model_ramped_spike

model_spike

review code - can make more similar to spike_date

model_spike_date

review code - may be room for optimisation
mask_spike - if is_mult, y=(A*mask_spike)+1.

model_ramped_spike:

single param A
Additional params, only used fixed
date_start_ramp, date_start, date_end_ramp, date_end
otherwise same as model_spike_date

mask_spike =

ramp from 0 to 1 between date_start_ramp, date_start
1 if date between (date_start, date_end)
ramp from 1 to 0 between date_end, date_end_ramp

capelastegui added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment