Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likelihood weighted inference does not return a table over all possible assignments #49

Closed
tawheeler opened this issue Jan 5, 2017 · 1 comment

Comments

@tawheeler
Copy link
Contributor

Running infer with a LikelihoodWeightingInference when some assignments have zero (or very low) likelihood will cause them to not show up in the samples. In these cases, the DataFrame returned will not have rows for those assignments.

It would be good to have a complete DataFrame factor, with entries for each assignment, even if the probability is zero.

@tawheeler
Copy link
Contributor Author

@hamzaelsaawy - if you could address this that'd be great. If you have a new discrete factor type we can use that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant