Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no async version of OnIncomingCall event #647

Open
nserj opened this issue Jan 4, 2022 · 1 comment
Open

There is no async version of OnIncomingCall event #647

nserj opened this issue Jan 4, 2022 · 1 comment
Labels
question sip

Comments

@nserj
Copy link
Contributor

nserj commented Jan 4, 2022

OnIncomingCall event will be called from async Task SIPTransportRequestReceived. Is there any reasons that OnIncomingCall is not async please?
@nserj nserj changed the title There is no async version of OnIncomingCall There is no async version of OnIncomingCall event Jan 4, 2022
@sipsorcery
Copy link
Member

The thread that fires the SIPTransportRequestReceived event is the thread that listens for incoming messages on that particular SIP channel. The OnIncomingCall event should not be doing anything long running or you'll ned up causing the underlying SIP channel to become unresponsive. The reason here is no async method is to encourage you to do what you need to do quickly or to get onto a different thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question sip
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sipsorcery @nserj