Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to use RTPSession with VP9 #635

Open
tribaud opened this issue Dec 8, 2021 · 1 comment
Open

Is there a way to use RTPSession with VP9 #635

tribaud opened this issue Dec 8, 2021 · 1 comment

Comments

@tribaud
Copy link

tribaud commented Dec 8, 2021

Hello,
we have done a Webrtc application with SIPSorcery 5.1.2 (not the latest) and SipSorcery.FFMpeg for video encoding.

We do not need audio and we actually achieve encoding video with ffmpeg on linux with H264 and VP8.

  • The video h264 is good but it works only with chrome browser as a client (Firefox disabled the support of H264 natively)
  • The video VP8 is using libvpx with one pass and the quality is really poor (but it works with a firefox client)

So we try to go to VP9:
We saw some unit tests in this repository dealing with VP9
And when we look in ffmpegVideoEncoder.cs it seems to be able to support VP9

But the question is : is it a big deal to add VP9 support in RTPSession ?

When we test it the Channel is closed with the VideoIncompatible reason....

return SetDescriptionResultEnum.VideoIncompatible;

Thanks for your answer.

@sipsorcery
Copy link
Member

sipsorcery commented Dec 8, 2021

The reason is here. You'll note there is no VP9 packetisation. Yet another thing I didn't get around to.

I haven't looked into it but I think VP8 and VP9 packetisation are the same, however, I could be wrong. If they are the same then in theory it would not be a big deal to add support to RTPSession. If not, it would be a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants