Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few errors reported by ESLint #59

Open
pdehaan opened this issue Mar 4, 2015 · 0 comments · May be fixed by #130
Open

A few errors reported by ESLint #59

pdehaan opened this issue Mar 4, 2015 · 0 comments · May be fixed by #130

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Mar 4, 2015

Randomly poking around the project and I ran ESLint (0.14.1) and saw a few errors which may be worth potentially considering if they are anything...

Here's my .eslintrc file (I did my best to turn off the rules which were causing the most noise):

env:
  node: true
  mocha: true

rules:
  comma-spacing: 0
  curly: 0
  dot-notation: 0
  eol-last: 0
  eqeqeq: 0
  key-spacing: 0
  new-cap: 0
  no-extra-boolean-cast: 0
  no-multi-spaces: 0
  no-process-exit: 0
  no-redeclare: 0
  no-shadow: 0
  no-trailing-spaces: 0
  quotes: [0, single]
  semi: 0
  space-infix-ops: 0
  strict: 0

And here are the results of running $ eslint .:

$ eslint .

lib/cli.js
  20:9  error  Illegal return statement

lib/middleware/auth.js
   1:4   error  request is defined but never used   no-unused-vars
   5:4   error  os is defined but never used        no-unused-vars
   6:4   error  url is defined but never used       no-unused-vars
   7:4   error  parseUrl is defined but never used  no-unused-vars
  31:25  error  Expected error to be handled        handle-callback-err

lib/middleware/confirm.js
   1:4   error  pkg is defined but never used  no-unused-vars
  13:95  error  Expected error to be handled   handle-callback-err

lib/middleware/creds.js
  1:4  error  path is defined but never used   no-unused-vars
  2:4  error  fs is defined but never used     no-unused-vars
  3:4  error  netrc is defined but never used  no-unused-vars

lib/middleware/deploy.js
    1:4  error  fs is defined but never used          no-unused-vars
    4:4  error  localCreds is defined but never used  no-unused-vars
    5:4  error  prompt is defined but never used      no-unused-vars
    9:4  error  surge is defined but never used       no-unused-vars
  115:6  error  verbose is defined but never used     no-unused-vars

lib/middleware/domain.js
  14:4  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  15:8  error  domain was used before it was defined                                  no-use-before-define
  30:7  error  Expected error to be handled                                           handle-callback-err

lib/middleware/email.js
  20:7  error  Expected error to be handled  handle-callback-err

lib/middleware/ipaddress.js
  3:18  error  Empty block statement  no-empty

lib/middleware/logout.js
  7:8  error  creds is defined but never used  no-unused-vars

lib/middleware/pkg.js
  3:20  error  Use path.join() or path.resolve() instead of + to create paths  no-path-concat

lib/middleware/prep.js
  17:32  error  e is defined but never used  no-unused-vars

lib/middleware/project.js
  33:9  error  Expected error to be handled  handle-callback-err

lib/middleware/shorthand.js
  1:4  error  path is defined but never used     no-unused-vars
  2:4  error  fs is defined but never used       no-unused-vars
  3:4  error  helpers is defined but never used  no-unused-vars

lib/middleware/size.js
   1:4   error  du is defined but never used  no-unused-vars
  28:21  error  Expected error to be handled  handle-callback-err

lib/middleware/tokencheck.js
  1:4  error  request is defined but never used   no-unused-vars
  4:4  error  prompt is defined but never used    no-unused-vars
  5:4  error  os is defined but never used        no-unused-vars
  6:4  error  url is defined but never used       no-unused-vars
  7:4  error  parseUrl is defined but never used  no-unused-vars

lib/middleware/util/helpers.js
  58:4  error  fetchToken is defined but never used  no-unused-vars

lib/middleware/util/skin.js
  8:2   error  Expected error to be handled   handle-callback-err
  8:16  error  err is defined but never used  no-unused-vars

lib/middleware/whitelist.js
  7:7   error  'param' is not defined  no-undef
  8:14  error  'param' is not defined  no-undef

✖ 40 problems (40 errors, 0 warnings)
kennethormandy added a commit that referenced this issue Aug 28, 2015
@kennethormandy kennethormandy linked a pull request Aug 28, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant