Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on CI [unicorn/expiring-todo-comments] #2405

Closed
cseas opened this issue Jul 22, 2024 · 1 comment
Closed

Not working on CI [unicorn/expiring-todo-comments] #2405

cseas opened this issue Jul 22, 2024 · 1 comment
Labels

Comments

@cseas
Copy link

cseas commented Jul 22, 2024

The expiring-todo-comments config is working when running ESLint on my local system but the failing todo isn't marked as Error when I'm running the same in my GitHub Actions CI.

unicorn/expiring-todo-comments

// ESLint config
{ 
    ...
    'unicorn/expiring-todo-comments': 'error',
}

// Expiring todo comment 
// Todo @cseas [2024-07-20]: Expecting this to fail on CI

I ran the date command on both my local system and the GitHub Action to try to debug this.
On system: Mon Jul 22 19:01:03 IST 2024
On CI: Mon Jul 22 13:33:06 UTC 2024

Even with the timezone difference, the todo still should've failed on CI for 2024-07-20.

@cseas cseas added the bug label Jul 22, 2024
@cseas
Copy link
Author

cseas commented Jul 22, 2024

Setting ignoreDatesOnPullRequests to false fixed it.

@cseas cseas closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant