-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextTransformerTest fails west side of GMT #138
Comments
OK forcing UTC will not help here, because the issue is in the translation files:
this uses default timezone. |
Hi, same here in France (Europe/Paris) - I think it is because of the "UNTIL" datetime value >here< : the "Z" at the end seems to actually specify/force the timezone to UTC, then to adapt the entered until datetime to our timezone (+1 hour in wintertime, +2 in summertime for Europe/Paris). Same forced then adapted datetime in "UNTIL" occures >here<, but because it is in the middle of the year and the hour is not checked (by the way, is it possible in the transformed text ?), this test passes. Best regards EDIT : the test can also be easily fixed by adding the following to the phpunit.xml file > phpunit element : <php>
<ini name="date.timezone" value="UTC" />
</php>
|
Hi,
actually the last test does not pass here, because of timezone issues:
For me in Europe/Berlin it results in
what makes sense, I think the code is correct, UTC midnight is 1:59 on january 1st on local. For each location east side of GMT the test passes (including America).
The test should force UTC timezone/starttime and maybe write another test for +/- timezones?
Best regards
Gregor
The text was updated successfully, but these errors were encountered: