Infinite loop setByMonthDay > 31

[NaWer]

Valid values are 1 to 31 or -31 to -1. It would be nice to raise error on invalid value, or min/max to avoid infinite loop.

Here is a test case :

$timezone    = 'America/New_York';
$startDate   = new \DateTime('2013-06-12 20:00:00', new \DateTimeZone($timezone));
$endDate     = new \DateTime('2013-06-14 20:00:00', new \DateTimeZone($timezone)); // Optional
$rule        = new \Recurr\Rule('FREQ=MONTHLY;COUNT=5', $startDate, $endDate, $timezone);
$rule->setByMonthDay(array(31)); // OK, june have only 30 days
$rule->setByMonthDay(array(32)); // Loop
$transformer = new \Recurr\Transformer\ArrayTransformer();

print_r($transformer->transform($rule));

[Edit] infinite loop on >= 32 and <= -33

[friedrichroell]

same issue with:

<?php

use Recurr\Rule;
use Recurr\Transformer\ArrayTransformer;

include_once 'vendor/autoload.php';

$startDate   = new DateTime('now');
$endDate     = new DateTime('+2 month');

$rule = (new Rule)
    ->setStartDate($startDate)
    ->setInterval(14)
    ->setFreq('DAILY')
    ->setByDay(['MO', 'TU'])
    ->setUntil($endDate)
;

$transformer = new ArrayTransformer();
$transformer->transform($rule);