Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put IE9 CDN CSS in conditional #38

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Put IE9 CDN CSS in conditional #38

merged 1 commit into from
Mar 24, 2015

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Mar 24, 2015

The example CDN code shows doesn't have the IE9 CSS file inside a conditional:

<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.1.1/gh-fork-ribbon.min.css" />
<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.1.1/gh-fork-ribbon.ie.min.css" />

This causes the ribbons to be mislaid if just copying and pasting, see #37.

Instead, add a conditional around the example code to prevent copy/paste errors:

<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.1.1/gh-fork-ribbon.min.css" />
<!--[if lt IE 9]>
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.1.1/gh-fork-ribbon.ie.min.css" />
<![endif]-->

Fixes #37.

Also fixes a "Github" -> "GitHub" typo.

simonwhitaker added a commit that referenced this pull request Mar 24, 2015
@simonwhitaker
Merge pull request #38 from hugovk/CDN-cond
2c6ab76 
Put IE9 CDN CSS in conditional
@simonwhitaker simonwhitaker merged commit 2c6ab76 into simonwhitaker:gh-pages Mar 24, 2015
@simonwhitaker
Copy link
Owner

Nice! Thank you!

@hugovk hugovk deleted the CDN-cond branch March 24, 2015 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDN-hosted CSS result in mislaid ribbons
2 participants
@hugovk @simonwhitaker