New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxAge for SessionCookies should be treated in seconds #22

Open

jalberto-ghub opened this issue Jan 27, 2021 · 1 comment

jalberto-ghub commented Jan 27, 2021

Do you want to request a feature or report a bug?
bug

What is the current behavior?
The value of maxAge for the cookie of the session-cookie is set as is (which will be treated as seconds). But the code treats this value as milli-seconds when cleaning the SessionCookie cache.

If the current behavior is a bug, please provide the steps to reproduce.
Set maxAge to a number of seconds. You will see the browser keep sending the cookie for that amount of time, But the cookie will be lost and a new one created after that amount of milliseconds.

What is the expected behavior?
The middletier should keep the SessionCookie for maxAge*1000

Please mention your java and java-express version.
version 0.2.1

jalberto-ghub mentioned this issue

SessionCookies should be maintained as long as the user returns within MaxAge seconds #23

Open

masecla22 commented Sep 11, 2021

This is addressed in my fork of this project.

https://github.com/masecla22/java-express
If you want to take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment