Identical numeric values considered different in diff

[marijnvdwerf]

(Source: https://decomp.me/scratch/xtJVv)

The target has 0x1, but the current version of the assembly displays 1. I'd expect it to not count as an actual difference.

Originally reported as decompme/decomp.me#816

[AngheloAlf]

This is not a bug, this is an actual difference. This is caused because of objdump's pseudo instructions.
You can see the actual difference in the scratch you posted by clicking on "Disable pseudo instructions".

[simonlindholm]

That said, it would be nice if we could convert hex li instructions into ori x, zero, imm to make this clearer, it's very confusing right now.

[AngheloAlf]

iirc the asm produced by psx compilers needs to be post-processed so it can match. The toolchain is a bit yucky.
It would be cool if asm-differ had an option to treat cases like this as the same instruction, but I don't think this should be enabled by default because this can be a real real difference on other compilers (it has at least happened on IDO)

[ethteck]

I think Simon just means we should convert the hex li instructions in the output of this tool, not actually editing the input. but yeah I agree after this convo we shouldn't consider these equal, probably ever really

or if we do want to, yeah, it could be an option

[ethteck]

(with pseudos off)

It seems we are treating some as equal, so that feels inconsistent