Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove params from DataObject::get() #10627

Open
4 tasks
emteknetnz opened this issue Dec 21, 2022 · 0 comments
Open
4 tasks

Remove params from DataObject::get() #10627

emteknetnz opened this issue Dec 21, 2022 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Dec 21, 2022

Following on from #10601 - remove the params from DataObject::get() - as mentioned in this comment, they should no longer be used

Acceptance Criteria

  • Params from DataObject::get() are removed
  • DataObject::get_one() is unaltered
  • Existing calls to DataObject::get() are updated to use DataList methods e.g. DataObject::get(MyDataObject::class, ["Foo" => "Bar"]) becomes MyDataObject::get()->filter(["Foo" => "Bar"])
  • silverstripe/framework branch is tested against a CI run of silverstripe/installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants