Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all setting parameter names lower case #1939

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

alerque
Copy link
Member

@alerque alerque commented Dec 16, 2023

Related to #1396

Subsequent to discussion here I took a stab at making all the setting parameter names lower case. There turned out to be a lot more of them in camelCase than I had realized. I had thought they were mostly lower case with a few camel case stragglers. Normalizing them all to lower case would have made sense.

I actually like camelCase better for this use case, so with this many changes I'm wondering if this actually makes sense. What if we made them all camelCase?

BREAKING CHANGE: We have to date used a mix of lowercase and camelCase
setting parameter names. For example 'spaceskip' was lower case but
'emergencyStretch' was camelCase. Now all parameter names are expected
to be fully lower case.
@alerque alerque modified the milestones: v0.15.0, v0.x.0 Dec 16, 2023
@alerque alerque force-pushed the develop branch 2 times, most recently from bf56e8f to 4a540c5 Compare May 30, 2024 14:07
@alerque alerque deleted the branch sile-typesetter:develop June 6, 2024 12:34
@alerque alerque closed this Jun 6, 2024
@alerque alerque reopened this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant