Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional GeneralNames in the SubjectAlternativeName #55

Closed
2 tasks
haydentherapper opened this issue Dec 20, 2023 · 1 comment · Fixed by #229
Closed
2 tasks

Support additional GeneralNames in the SubjectAlternativeName #55

haydentherapper opened this issue Dec 20, 2023 · 1 comment · Fixed by #229
Assignees
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

See https://github.com/sigstore/sigstore-go/blob/main/pkg/fulcio/certificate/summarize.go#L64

  • Support OtherName, used by Fulcio for user names in certificates (not currently in use in production)
  • Support parsing additional GeneralNames like DNS, for BYO PKI use cases
@haydentherapper haydentherapper added the enhancement New feature or request label Dec 20, 2023
@cmurphy cmurphy self-assigned this Jun 28, 2024
@cmurphy
Copy link
Contributor

cmurphy commented Jul 12, 2024

#229 adds support for parsing OtherName in fulcio certificates.

The function linked is only used for parsing Fulcio certificates, and I don't think Fulcio can issue certificates with other GeneralNames as SANs: https://github.com/sigstore/fulcio/blob/main/docs/oid-info.md

Does sigstore-go support "BYO PKI"? I'm wondering if the second bullet point needs to be completed if there's not yet an identifiable use case, or if we could elaborate on the expected workflow for a DNS-type identity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants