Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature is pushed without tag when using COSIGN_REPOSITORY #322

Closed
yan opened this issue May 13, 2021 · 0 comments · Fixed by #323
Closed

Signature is pushed without tag when using COSIGN_REPOSITORY #322

yan opened this issue May 13, 2021 · 0 comments · Fixed by #323

Comments

@yan
Copy link

yan commented May 13, 2021

Description

When using cosign sign with COSIGN_REPOSITORY set and attempting to sign an image in ECR, the signature is pushed without tag.

Example invocation:

COSIGN_REPOSITORY=image_signatures cosign sign -key me.key <account_id>.dkr.ecr.us-west-2.amazonaws.com/<image>:<tag>

The signature gets pushed to the proper repo, although the <sha>.sig tag is stripped.

More info
It looks like DestinationRef() in pkg/cosign/upload.go strips the tag when assembling the final URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant