-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 404 returned as JSON instead of HTML. #33
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
At the moment, all 404 errors are handled by express, and this results in a JSON response being returned when a non-existing page from static is called. This is not very elegant and ideally this needs to be handled by React. However, this means, the server will send a 200 even for non-existing route even though it is a 404 and only then the frontend will know about the non-existing page. This situation needs to be fixed to wither send index.html with a 404 in invalid route or have a separate API prefix and handle frontend and backend 404s separately as @juliolopeztorres suggests.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: