-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use something else than Google Maps for maps #76
Comments
To make it work with Expo, we could use a 100% JS solution: https://github.com/reggie3/react-native-webview-leaflet or https://github.com/allenhwkim/react-openlayers Performance is not an issue here (the map is mostly decorative), so we don't need a native component |
Still open ? |
Yes! It'd be good to see what's out there, and with what we can replace it. The requirements are:
@theaupoulat would you like to work on this? |
I have similar requirements for a project so I'll gladly help! My first intuition is leaflet too. |
@amaurymartiny Having problems with algolia API, keep getting 403 errors on each search (I put algolia keys). Is it a known issue when setting development env ? |
Hmm, I'm not sure, is there an error message with the 403? Alternatively, try setting |
It was a version problem with react-native-reanimated and expo. Solved it ! thanks ! |
Hi @theaupoulat! Any progress on your side? Are you still interested in working on this? |
I can give this a shot if you guys don't mind! |
Sure 🚀! @theaupoulat hasn't been answering, so go ahead @LuKenneth, I just assigned you. |
So I started taking a look at this tonight, I got the app running on my iPhone with no problems. Then I began looking into replacing the map provider with open street maps. What I successfully did was add a 'UrlTile' on the map to use open street maps, but I believe that's just an overlay over the existing map provider, which isn't what we're looking for. I decided I needed to make my attempts on an android device so that I could see the default Google Maps being replaced. I discovered this package (https://www.npmjs.com/package/react-native-maps-osmdroid) which seems to seamlessly replace google maps with open street maps on android. I |
Hey @LuKenneth, yeah that happens when you have an incorrect sentry DSN. Try to put Note: I updated the README too, you're not the first one to ask this |
Hey @LuKenneth, are you still working on this? Do you need any help? |
@amaurymartiny Sorry, I've been busy/traveling lately. Using |
@amaurymartiny I remember where i was now... I tried to use https://github.com/allenhwkim/react-openlayers and https://github.com/allenhwkim/react-openlayers, but for each - I had trouble importing it because they don't have typed equivalents. Is my only option to created the typed module myself? That would be something brand new to me. Any advice? |
No, you have several options:
declare module 'react-openlayers'; And everything in react-openlayers will have the
// eslint-disable-next-line
// @ts-ignore
import openLayers from 'react-openlayers'; If |
We plan to launch the app in China (where pollution is serious). However, we're using google maps, which is blocked.
An alternative would be mapbox, but we need to make sure it's not blocked in China. Or better: open street map.
Also, this might require ejecting from Expo.If possible, let's not eject from Expo.The text was updated successfully, but these errors were encountered: