Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to Spanish 馃嚜馃嚫 #74

Closed
amaury1093 opened this issue Apr 17, 2019 · 9 comments 路 Fixed by #83
Closed

Translate to Spanish 馃嚜馃嚫 #74

amaury1093 opened this issue Apr 17, 2019 · 9 comments 路 Fixed by #83
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amaury1093
Copy link
Member

amaury1093 commented Apr 17, 2019

We would appreciate some help for translating Sh**t! I Smoke to Spanish.

Here's a detailed guide on how to get started with translations: https://github.com/amaurymartiny/shoot-i-smoke/wiki/How-to-contribute-with-translations%3F

@amaury1093 amaury1093 added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 17, 2019
@OlgaMorales
Copy link
Contributor

@amaurymartiny i'd like to help u

@amaury1093
Copy link
Member Author

Nice, that would be very helpful! If you create a Pull Request with the Spanish translations (an es.json), I'll merge it asap.

Have a look at the wiki link on the 1st post. Ping me if you need help with which text goes where, or how to give your translations a try in the app.

@OlgaMorales
Copy link
Contributor

@amaurymartiny it's my PR ready

@OlgaMorales
Copy link
Contributor

@amaurymartiny done!

@amaury1093
Copy link
Member Author

Thanks @OlgaMorales for #79. However, I found out that there were still a couple of strings in the app which were in English (it was my fault, I forgot to put them in en.json).

Would you like to continue working on the new ones? There are here: https://github.com/amaurymartiny/shoot-i-smoke/pull/81/files#diff-d74a2d947ea7e5d2e9ef65b18a8d5a70R42, in green. If yes, you can create a new PR for that.

@OlgaMorales
Copy link
Contributor

sure @amaurymartiny

@lucienbl
Copy link
Contributor

Don't you want using poeditor which would really be simpler? 馃槀

@amaury1093
Copy link
Member Author

@lucienbl I'll have a look at that, I promise!

@OlgaMorales
Copy link
Contributor

new pull request done ! @amaurymartiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants