-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember location #727
Comments
That's a very good idea! Would you like to create a PR for this? |
save the location given by network if location permission is not granted |
I'm happy to have a go at this if I could get some pointers. Here's my rough plan of action: I can use |
Is it better to set the default state value to the last saved location or should we instead attempt GPS first and only fall back if there's an error? |
We should definitely do that. If the user physically moves (e.g. go to another city), we want to show the pollution of the new city, and not the previously stored one. AsyncStorage is definitely the way to go 👍 So the flow is:
Does this make sense @HaramanJohal ? What do you think about it? I assigned you, let me know if you need help! And thanks for volunteering! |
This makes sense, and the flow seems logical, I'll give it a go and let you know if I get stuck. |
If you do not give location permissions to the app you have to type in your location every time you launch.
I think it would be preferable to remember the last location used if location permissions are disabled.
The text was updated successfully, but these errors were encountered: