Calculating Max Cigarattes to display dynamically #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sarthakpranesh <[email protected]>
|
|
|
Wow, thanks, I'll have a look tonight. |
amaury1093
reviewed
Oct 1, 2020
App/Screens/Home/Home.tsx
Outdated
Comment on lines
71
to
81
| const height = scale( | ||
| count <= THRESHOLD.FIRST | ||
| ? SIZES.BIG | ||
| : count <= THRESHOLD.SECOND | ||
| ? SIZES.MEDIUM | ||
| : count <= THRESHOLD.THIRD | ||
| ? SIZES.BIG | ||
| : count <= THRESHOLD.FOURTH | ||
| ? SIZES.MEDIUM | ||
| : SIZES.SMALL | ||
| ); |
There was a problem hiding this comment.
This code is used twice, could you factor it out in a separate function getCigarettesHeight?
There was a problem hiding this comment.
Changes applied 👍
added 2 commits
October 2, 2020 10:13
Signed-off-by: sarthakpranesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the total number of cigarettes it will take to completely fill two rows dynamically according to the screen width and assigning it to
showMaxCigarettescloses #440
Signed-off-by: sarthakpranesh [email protected]