Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab "Simple React" doesn't have footer #499

Closed
vtamara opened this issue Mar 29, 2022 · 0 comments · Fixed by #534
Closed

Tab "Simple React" doesn't have footer #499

vtamara opened this issue Mar 29, 2022 · 0 comments · Fixed by #534

Comments

@vtamara
Copy link

vtamara commented Mar 29, 2022

image
Yassa-hue added a commit to Yassa-hue/react-webpack-rails-tutorial that referenced this issue Jul 20, 2023
@Yassa-hue
Create Footer component (shakacode#499)
df0ca97 
This commit basically should add a footer to the Simple React page,
But The footer logic is used in more than one place so
a Footer component is created and called wherever it is needed.

Resolves shakacode#499
@Yassa-hue Yassa-hue mentioned this issue Jul 20, 2023
Merged
justin808 pushed a commit that referenced this issue Jul 25, 2023
@Yassa-hue
Create Footer component (#499) (#534)
97c1ac5 
* Create Footer component (#499)

This commit basically should add a footer to the Simple React page,
But The footer logic is used in more than one place so
a Footer component is created and called wherever it is needed.

Resolves #499

* Move Footer to application layout

The Footer should appear in all the pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Footer component (#499) Yassa-hue/react-webpack-rails-tutorial
1 participant
@vtamara