Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shakacode/react-webpack-rails-tutorial
base: master
Choose a base ref
...
head repository: shakacode/react-webpack-rails-tutorial
compare: improve-docker-image
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 7 files changed
  • 1 contributor

Commits on Dec 9, 2023

  1. Prepare db only if rails server is running

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    3333011 View commit details
    Browse the repository at this point in the history

  2. Update root Dockerfile based on Rails Dockerfile

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    aa89a2b View commit details
    Browse the repository at this point in the history

  3. Remove bootsnap related lines

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    de97aab View commit details
    Browse the repository at this point in the history

  4. Use bin/rails

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    e611dee View commit details
    Browse the repository at this point in the history

  5. Fix execution of the command for generative locale

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    eaa0f9f View commit details
    Browse the repository at this point in the history

  6. Remove storage dir from the chown command

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    4b75008 View commit details
    Browse the repository at this point in the history

  7. Move node installation to the base stage

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    92df56f View commit details
    Browse the repository at this point in the history

  8. Rename the working dir to /app

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    8e66c95 View commit details
    Browse the repository at this point in the history

  9. Move build steps into cpln dockerfile

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f1b9b8c View commit details
    Browse the repository at this point in the history

  10. Move customizations into dedicated Dockerfiles

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f564a84 View commit details
    Browse the repository at this point in the history

  11. Use full command for rails server 

    This is to match Rails scripts for doployment
    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    5ad32b1 View commit details
    Browse the repository at this point in the history

  12. Use bash to run the entrypoint script 

    This is needed to be able to run the conditions with ==.
    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    d9bd05b View commit details
    Browse the repository at this point in the history

  13. Add documentation for using base docker image

    @ahangarha
    ahangarha committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    ed2f9d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Add yarn res:build to the new dockerfile

    @ahangarha
    ahangarha committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    6400c7a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Improve documentation

    @ahangarha
    ahangarha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    24d87db View commit details
    Browse the repository at this point in the history

  2. Change the repository of the base image

    @ahangarha
    ahangarha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    eef5a7b View commit details
    Browse the repository at this point in the history

  3. Add maintainer guideline

    @ahangarha
    ahangarha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    72712d4 View commit details
    Browse the repository at this point in the history