Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate concept of default source by moving to array responses of content and translations #1879

Open
Tracked by #1877
Harjot1Singh opened this issue Jul 10, 2022 · 0 comments
Open
Tracked by #1877

Encapsulate concept of default source by moving to array responses of content and translations #1879

Harjot1Singh opened this issue Jul 10, 2022 · 0 comments
Labels
Effort 2 Well-sized task (simple code + tests). ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.

Comments

@Harjot1Singh
Copy link
Member

Harjot1Singh commented Jul 10, 2022 •
edited
Loading

Summary

As there are multiple sources of both content and translations, an end user may not know which source to use for content and translations, per composition. A clean way of modelling around this is to represent content and translation values as arrays, ordered by our recommendation for the line.

Approach

Change the JSON representation to use arrays, rather than objects to represent the value of content/gurbani and translations.
@Harjot1Singh Harjot1Singh mentioned this issue Jul 10, 2022
Open
3 tasks
@Harjot1Singh Harjot1Singh added ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed. Effort 2 Well-sized task (simple code + tests). labels Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort 2 Well-sized task (simple code + tests). ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.
Projects
Project Management
Status: Ready for Development
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Harjot1Singh