Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'source_line' from data #1872

Open
sarabveer opened this issue Jan 24, 2022 · 2 comments
Open

Drop 'source_line' from data #1872

sarabveer opened this issue Jan 24, 2022 · 2 comments
Labels
Effort 1 Simple task (code/non-code)

Comments

@sarabveer
Copy link
Collaborator

This is an unmaintained field. Outside of Sri Guru Granth Sahib Ji, all the other compositions do not use this field in the intended manner or it is left null. Line numbers vary from source to source.

@bhajneet
Copy link
Member

I understand this is an unmaintained/mis-used field currently. In the future, could this be used to locate lines programmatically in PDFs?

@sarabveer
Copy link
Collaborator Author

I understand this is an unmaintained/mis-used field currently. In the future, could this be used to locate lines programmatically in PDFs?

The line number (and even page number) varies from source to source. So at the current moment, the only PDF it could theoretically work with is Dr. Kulbir S. Thind's SGGS PDF (and that is assuming the source_line data is correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 1 Simple task (code/non-code)
Projects
None yet
Development

No branches or pull requests

3 participants