build: generate only heavy vishraams in vishraam_first_letters column and strip line endings from first_letters
#1776
Conversation
first_lettersvishraam_first_letters column and strip line endings from first_letters
It's the same issue. Originally desktop, then GU, and finally DB. I assume once this is done and desktop is coupled it will Just Work™️, if not then please FAI for what is still required |
|
This pull request introduces 1 alert when merging 90cb86d into 7097e36 - view on LGTM.com new alerts:
|
| vishraam_first_letters: [ | ||
| stripEndings, | ||
| // Retain heavy vishraams only | ||
| text => stripVishraams( text, { light: true, medium: true } ), |
There was a problem hiding this comment.
it's odd that you have to choose what to strip (I'd expected all weights by default and code having to toggle heavy: false)
There was a problem hiding this comment.
All weights are stripped by default, but if you supply options, then you choose which are (because I thought it'd more be confusing to specify which you'd exclude in a strip function)
There was a problem hiding this comment.
I think it makes more sense to change parameters to affect the default. So if the default is light, medium, heavy true. You'd put in a parameter to make one of these false. But if you think this makes more sense to people, that's fine -- I am not up to date on these conventions lol
|
Do you think it's maybe worth doing the english translit or hindi translit first letters in this PR? |
No, but I can do a follow up PR very quickly since i'm in the zone lol |
Summary of PR
Retains only the heavy vishraams in the
vishraam_first_letterscolumn, to allow for #1775. Removes any line endings from first letters.Tests for unexpected behavior
Time spent on PR
20 mins
Linked issues
Fix #1775
I cannot find the issue for removing pauses from first letters, if there is one.
Reviewers
@bhajneet