Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): replace open-yaiya characters with new codepoint #1784

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix(data): replace open-yaiya characters with new codepoint #1784

merged 1 commit into from
Jun 12, 2020

Conversation

sarabveer
Copy link
Collaborator

Summary of PR

Replaced open-top yaiya characters with a new character used by ASCII font

Time spent on PR

nine_thousand_years

Linked issues

Fix #1758

@sarabveer sarabveer added Status: Merge Scope: Data/Sri Dasam Granth ○ Type Bug Regressions/production issues that do not function as intended. Effort 0 Non-work/tracking labels Jun 7, 2020
@sarabveer sarabveer requested a review from bhajneet June 7, 2020 18:22
@bhajneet
Copy link
Member

bhajneet commented Jun 7, 2020

@Harjot1Singh @swissarmykirpan an excellent example use case for #1388

@bhajneet
Copy link
Member

bhajneet commented Jun 7, 2020

@sarabveer Were there no instances of í (U+00ED) -> adha-yaiyha with no line over top to change?

@sarabveer
Copy link
Collaborator Author

@sarabveer Were there no instances of í (U+00ED) -> adha-yaiyha with no line over top to change?

nope. make sure to have it case-sensitive.

@Harjot1Singh Harjot1Singh merged commit 4b84008 into shabados:dev Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 0 Non-work/tracking Scope: Data/Sri Dasam Granth ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update db with new yaiyya characters from new font
3 participants