Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isBani field to banis to designate/differentiate between bookmarks and banis #1389

Open
bhajneet opened this issue Feb 13, 2020 · 2 comments
Open

Add isBani field to banis to designate/differentiate between bookmarks and banis #1389

bhajneet opened this issue Feb 13, 2020 · 2 comments
Assignees
@saihaj
Labels
Effort 1 Simple task (code/non-code) Impacts Some Affects the average end-user. □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

Not all items in the banis.json are banis. They are better considered bookmarks for apps. If someone would like only the banis from list, they should be able to query them specifically.
@bhajneet bhajneet added Impacts Some Affects the average end-user. Status: Confirmed labels Feb 13, 2020
@bhajneet bhajneet mentioned this issue Feb 13, 2020
Merged
@Harjot1Singh Harjot1Singh added Effort 1 Simple task (code/non-code) Status: On Hold labels Feb 27, 2020
@Harjot1Singh Harjot1Singh changed the title Refactor banis as bookmarks, add tags to bookmarks to designate/differentiate Add isBani field to banis to designate/differentiate between bookmarks and banis Feb 27, 2020
@Harjot1Singh Harjot1Singh added □ Type Story Feature or requirement written from the user's perspective using non-technical language. and removed Status: On Hold labels Feb 27, 2020
@bhajneet bhajneet mentioned this issue Feb 28, 2020
Open
@bhajneet
Copy link
Member Author

bhajneet commented May 4, 2020

@saihaj

@saihaj
Copy link
Member

saihaj commented May 9, 2020

  • Add field in schema
  • Update docs with new schema image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saihaj saihaj

Labels
Effort 1 Simple task (code/non-code) Impacts Some Affects the average end-user. □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Harjot1Singh @sarabveer @bhajneet @saihaj