Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide for implementing multimodal models? #501

Open
amosyou opened this issue Jun 4, 2024 · 0 comments
Open

guide for implementing multimodal models? #501

amosyou opened this issue Jun 4, 2024 · 0 comments

Comments

@amosyou
Copy link
Contributor

amosyou commented Jun 4, 2024

I read this comment about how to adapt vllm implementations for sglang. I was wondering if there were any pointers on how to implement vision-language models for sglang? I've been reading through llava.py and it's not entirely clear to me what I need to change from a typical huggingface implementation.

Also, I was wondering why there's no check for ForwardMode.PREFILL in the forward function for LlavaLlamaForCausalLM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant