-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "save state" after tab duplication #416
Comments
Actually there appear to be more serious issues associated with this feature push. I just lost a whole tab (with its own unique local_id) just upon refreshing - somehow the whole local storage state is gone and all I am left with is an empty neuroglancer page. I recognize that this warrants filing a separate bug, but for now I am just attaching the bug label and documenting this incident here as it's largely related. |
There is a history mechanism with the new save state module. The "$" shows all previously saved/shared states. If this state was shared, see if loading it from the history restores it. The error suggest that either the key doesn't exist or it does and the state it maps to is invalid. With regard to save state duplication this is the intended behavior. Their is a little yellow warning dialog that warns against duplicating tabs primarily because the local_id is being utilized. Ideally, the local_id should never be utilized by the user for any reason and is only visible currently to preserve the tab in the case of reload/crashes. In the future, the local_id will be completely internal. The only thing the user will see is the neuroglancer.com. The proper and unfortunately less intuitive way to duplicate a tab is to "share" that state with yourself, i.e duplicate the JSON link. |
Local state disappearing from the state dict (would cause lost of state upon page refresh) happened for a third time today. local_id in three of my browser tabs are not found in the state dict, two of the three are current/foreground tabs of the respective window that I had left open from before the weekend. Chromium browser, version 80.0.3987.87. |
This disappearing-state issue appears to be due to overwriting the whole dict when writes happen from different tabs. |
I guess I wasn't clear in my previous message (and private message) this is now 100% of the time reproducible. Steps to reproduce:
And It feels this could be something related to javascript closures or something |
Should be resolved by #429 If two tabs are modifying the same state, the ID of the older one will change. |
Not sure whether to file this as a feature
(if at all feasible)or bug:After the recent "save state" update, upon duplicating a tab (with neuroglancer in it) in chrome , the new tab shares the same state session id (or whatever it is called) as its sibling and causes the two tabs to covertly overwrite each other while still appearing different. The user would not notice loss of the state until closing and recovering the tab (for example, upon tab recovery after restarting chrome)
In my workflow I frequently duplicates my chrome tab to test out different dataset layers or look at different locations of same datasets and this would be a huge inconvenience, if not a problem.
Mitigation options in mind:
The text was updated successfully, but these errors were encountered: