Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ‎TypedArray::update safe #446

Closed
gterzian opened this issue Jan 10, 2024 · 3 comments
Closed

Make ‎TypedArray::update safe #446

gterzian opened this issue Jan 10, 2024 · 3 comments

Comments

@gterzian
Copy link
Member

I think ‎TypedArray::update can be made safe, while containing an unsafe block calling Self::update_raw, that way we can remove these kind of unsafe blocks in Servo.

@Taym95
Copy link
Contributor

Taym95 commented Feb 11, 2024

How do you think we can do this @gterzian, from code I see unsafe code call is chained, update -> update_raw -> copy_nonoverlapping

@gterzian
Copy link
Member Author

gterzian commented Feb 12, 2024

I think update should simply be safe externally, but internally have an unsafe block that calls update_raw(Otherwise there is no point in update_raw).

@Taym95
Copy link
Contributor

Taym95 commented Aug 16, 2024

this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants