Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UIKIT-3864): fixed menuItemsCreator timing #89

Merged
merged 1 commit into from
May 12, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented May 12, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

UIKIT-3864

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this May 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c8402af) 13.98% compared to head (279fd98) 13.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   13.98%   13.98%   -0.01%     
==========================================
  Files         313      313              
  Lines        6186     6187       +1     
  Branches     1691     1691              
==========================================
  Hits          865      865              
- Misses       5257     5258       +1     
  Partials       64       64              
Impacted Files Coverage Δ
...nelSettings/component/GroupChannelSettingsMenu.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bang9 bang9 merged commit 057662c into main May 12, 2023
@bang9 bang9 deleted the fix/groupChannelSettingsMenu branch May 12, 2023 07:48
@bang9 bang9 changed the title [UIKIT-3864] Fix/fixed menuItemsCreator timing fix(UIKIT-3864): fixed menuItemsCreator timing Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants