Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.4.18 #139

Merged
merged 3 commits into from
Jun 26, 2024
Merged

RC 1.4.18 #139

merged 3 commits into from
Jun 26, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Jun 9, 2024

PyGPSClient Pull Request Template

Description

  1. Fix PUBX03 NMEA handling for Sky View - Fixes Incorrect PUBX03 elev/azim handling in Sky View #138
  2. Make PUBX03 SVID numbering consistent with GSV

Fixes #138

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain test coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Jun 9, 2024
@semuadmin semuadmin added this to the RC 1.4.18 milestone Jun 9, 2024
@semuadmin semuadmin self-assigned this Jun 9, 2024
@semuadmin semuadmin marked this pull request as draft June 9, 2024 18:26
@semuadmin semuadmin marked this pull request as ready for review June 26, 2024 06:33
@semuadmin semuadmin merged commit 56f1a0d into master Jun 26, 2024
5 checks passed
@semuadmin semuadmin deleted the RC-1.4.18 branch June 26, 2024 06:33
Williangalvani pushed a commit to Williangalvani/PyGPSClient that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect PUBX03 elev/azim handling in Sky View
1 participant