Add props to cloned future to fix rerun name #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutralino1
approved these changes
Jan 8, 2023
There was a problem hiding this comment.
Damn, I've been chasing this issue for a month! Thank you so much @kamalesh0406
|
Can you merge the PR @neutralino1, I cannot merge it. :( |
|
merged. Thanks @kamalesh0406 ! |
jrcribb
pushed a commit
to jrcribb/sematic
that referenced
this pull request
Apr 9, 2024
This PR fixes issue sematic-ai#393 . I chose to hardcode the props for name and tags because https://github.com/sematic-ai/sematic/blob/main/sematic/db/models/factories.py#L30 erases the name and tags from the existing future. It seems like for normal runs `.set` is called after this which sets the props but it doesn't seem to be the case for rerun resolutions. At least from my understanding, this is why this issue happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #393 . I chose to hardcode the props for name and tags because https://github.com/sematic-ai/sematic/blob/main/sematic/db/models/factories.py#L30 erases the name and tags from the existing future. It seems like for normal runs
.setis called after this which sets the props but it doesn't seem to be the case for rerun resolutions.At least from my understanding, this is why this issue happens.