Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 Support #1152

Closed
omonk opened this issue Feb 23, 2021 · 11 comments
Closed

React 17 Support #1152

omonk opened this issue Feb 23, 2021 · 11 comments

Comments

@omonk
Copy link

omonk commented Feb 23, 2021

Are there any plans to bump the react and react-dom peer dependencies to allow react 17? With the npm version 7 reintroduction of installing peer dependencies it is making it tricky to use evergreen without the --legacy-peer-deps flag.

@mothattack
Copy link

Yeah I was about to start a project with React and Evergreen. Step 1 install react. Step 2 install evergreen Step 3 .......oh...step 2 failed

@Samuel-Montoya
Copy link

When will this get updated? Such a great package and would love to use it with latest version of React

@akleiner2
Copy link
Contributor

Hey y'all -- will look into this before the week's done. My guess is it's as simple as loosening up the peer deps requirement (or getting rid of it altogether) to allow for React 17 (especially since there aren't really any major breaking changes in React 17), but I want to be 100% sure first and test locally. Thanks for the patience here 🤞

@mothattack
Copy link

Any updates on this?

@mikemaccana
Copy link

This should hopefully be a small update as you say - as there's no breaking changes between React 16 and 17. next.js users can't upgrade to next 11 until Evergreen supports React 17 so it would be timely if the dependencies were updated.

@mirnax3
Copy link

mirnax3 commented Jul 8, 2021

Any updates.....?

@zuhair-naqvi
Copy link

Thumbs up for React 17 please!

@mshwery
Copy link
Contributor

mshwery commented Jul 28, 2021

Hey folks, quick update – we've made some upgrades internally and with packages that would have led to a breakage on React 17 (this only affects certain components).

Right now it seems the last package that we'll need to fork or switch off of is react-tiny-virtual-list due to its reliance on deprecated lifecylece method names.

I started looking into switching to react-window which seems to be the defacto standard these days, but it's noticeably slower than react-tiny-virtual-list (this will affect SelectMenu, Table.VirtualBody, and Autocomplete components).

@mshwery
Copy link
Contributor

mshwery commented Jul 29, 2021

Ok, gonna cut a release soon now that these have landed:

@mshwery
Copy link
Contributor

mshwery commented Jul 29, 2021

Released with v6.3.0!

@mshwery mshwery closed this as completed Jul 29, 2021
@omonk
Copy link
Author

omonk commented Jul 30, 2021

@mshwery - many thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants