Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flops reported in the paper might be wrong #34

Open
peymanrostami opened this issue Sep 19, 2024 · 0 comments
Open

Flops reported in the paper might be wrong #34

peymanrostami opened this issue Sep 19, 2024 · 0 comments

Comments

@peymanrostami
Copy link

Hello,

Thank you for your great work.

I am working on the retrieval tasks on flicker30k using the clip model. I have noticed that in table 10 of the UPop paper, the number of flops of the uncompressed model is reported as 395.7 GFLOPs. however, it seems that this value is also including the flops of the momentum models visual_m and transformer_m. but these models should be thrown away after the training is finished, right? So, I think the actual flops should be half of the reported values in the paper.

note that the output of the print_params_and_flops('retrieval_clip', model, device, config) also considers the parameters and flops of the momentum models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant