Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spider attr #235

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Gallaecio
Copy link
Contributor

Continuation of #15.

Related to #11, although since it works at the spider level, not at a wider, project level, I wouldn’t say it fixes it.

pawelmhm and others added 8 commits August 12, 2019 16:58
* removed process_html (render response in html feature) from this PR
* removed remote request tests with extra spider
* refactors tests from functions to objects inheriting
from unittest.TestCase
* adds tests for enabling middleware with spider attribute
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #235 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   92.67%   92.74%   +0.07%     
==========================================
  Files           9        9              
  Lines         587      593       +6     
  Branches      118      119       +1     
==========================================
+ Hits          544      550       +6     
  Misses         21       21              
  Partials       22       22
Impacted Files Coverage Δ
scrapy_splash/middleware.py 89.92% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40ca4f...40961cb. Read the comment docs.

@Gallaecio Gallaecio mentioned this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants