Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please Can we do a new release for all the changes merged in master since 8.0 in October'21 #307

Closed
DharmeshPandav opened this issue Nov 4, 2022 · 5 comments · Fixed by #309
Closed

Please Can we do a new release for all the changes merged in master since 8.0 in October'21 #307

DharmeshPandav opened this issue Nov 4, 2022 · 5 comments · Fixed by #309

Comments

@DharmeshPandav
Copy link

0.8.0...master

One that's nagging me is the following warning in my logs, for which the fix was applied in this PR #269.

if not major, can we please have a minor release 0.8.1 ?

[py.warnings] /usr/local/lib/python3.10/site-packages/scrapy_splash/[request.py:42](http:https://request.py:42/): ScrapyDeprecationWarning: Call to deprecated function to_native_str. Use to_unicode instead. Less

  url = to_native_str(url)
@mrhaanraadts
Copy link

It's no warning anymore.
to_native_str was removed from Scrapy 2.8.0

@DharmeshPandav
Copy link
Author

Possibly not being maintained @kmike @pablohoffman

@Gallaecio
Copy link
Contributor

Oops. On it…

@Gallaecio Gallaecio mentioned this issue Feb 3, 2023
Merged
@kmike kmike closed this as completed in #309 Feb 3, 2023
@Gallaecio
Copy link
Contributor

0.9.0 is out now, thanks!

@DharmeshPandav
Copy link
Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare scrapy-splash 0.9.0 Gallaecio/scrapy-splash
3 participants
@Gallaecio @DharmeshPandav @mrhaanraadts