Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response type still not determined correctly sometimes #215

Open
lopuhin opened this issue Apr 5, 2019 · 1 comment
Open

Response type still not determined correctly sometimes #215

lopuhin opened this issue Apr 5, 2019 · 1 comment
Labels

Comments

@lopuhin
Copy link
Contributor

lopuhin commented Apr 5, 2019

Here is a traceback (without a way to reproduce unfortunately), which shows that most likely we still sometimes don't identify response type correctly:

[scrapy.core.scraper] Error downloading <POST https://xxx-splash.scrapinghub.com/render.json>
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
    result = g.send(result)
  File "/usr/local/lib/python2.7/site-packages/scrapy/core/downloader/middleware.py", line 53, in process_response
    spider=spider)
  File "/usr/local/lib/python2.7/site-packages/scrapy_splash/middleware.py", line 387, in process_response
    response = self._change_response_class(request, response)
  File "/usr/local/lib/python2.7/site-packages/scrapy_splash/middleware.py", line 402, in _change_response_class
    response = response.replace(cls=respcls, request=request)
  File "/usr/local/lib/python2.7/site-packages/scrapy/http/response/text.py", line 54, in replace
    return Response.replace(self, *args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/scrapy/http/response/__init__.py", line 81, in replace
    return cls(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/scrapy_splash/response.py", line 33, in __init__
    super(_SplashResponseMixin, self).__init__(url, *args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'encoding'

scrapinghub-stack-scrapy:1.4 is used, scrapy-splash version is 0.7.2

@Gallaecio Gallaecio added the bug label Nov 21, 2019
@Gallaecio
Copy link
Contributor

I’m not sure how to fix this without a way to reproduce it ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants